Skip to content

Get rid of ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS to reduce the tensi… #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2023
Merged

Get rid of ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS to reduce the tensi… #3869

merged 2 commits into from
Sep 1, 2023

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Aug 30, 2023 •
edited
Loading

…on between develop and K2 branches

WA for KT-61577

@qwwdfsad
Copy link
Member Author

NB: don't merge unless we have a ticket to mention

@nikitabobko
Copy link
Member

nikitabobko commented Aug 30, 2023 •
edited
Loading

If you're going to merge this then please don't forget to drop unnecessary @Suppress("NO_ACTUAL_CLASS_MEMBER_FOR_EXPECTED_CLASS")

~/jb/test-proj/kotlinx.coroutines $ grep -r 'Counterpart for @Suppress'
kotlinx-coroutines-core/jvm/test/TestBase.kt:    // Counterpart for @Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")
kotlinx-coroutines-core/native/test/TestBase.kt:@Suppress("NO_ACTUAL_CLASS_MEMBER_FOR_EXPECTED_CLASS") // Counterpart for @Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")
kotlinx-coroutines-core/js/test/TestBase.kt:@Suppress("NO_ACTUAL_CLASS_MEMBER_FOR_EXPECTED_CLASS") // Counterpart for @Suppress("ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS")

@qwwdfsad qwwdfsad closed this Sep 1, 2023
@qwwdfsad qwwdfsad reopened this Sep 1, 2023
@qwwdfsad qwwdfsad merged commit 9d1c62a into develop Sep 1, 2023
@qwwdfsad qwwdfsad deleted the k2-workaround-backport branch September 1, 2023 15:28
woainikk pushed a commit that referenced this pull request Sep 2, 2023
@qwwdfsad @woainikk
Get rid of ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS to reduce the tensi… (
f31f7bb 
#3869)

* Get rid of ACTUAL_FUNCTION_WITH_DEFAULT_ARGUMENTS to reduce the tension between develop and K2 branches
* Remove obsolete workaround

Target ticket: KT-61577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @nikitabobko